feat: emit manifest.json for PWA support#60
Open
ilfroloff wants to merge 1 commit intoswingmx:masterfrom
Open
Conversation
- Set manifestFilename to "manifest.json" in the VitePWA plugin so the build outputs /manifest.json instead of /manifest.webmanifest. Browsers and the Swing Music server both expect the .json extension. - Remove public/site.webmanifest (empty placeholder with wrong icon paths; superseded by VitePWA-generated manifest.json).
|
Illia Fralou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The VitePWA plugin defaults to generating
manifest.webmanifest.Browsers and the Swing Music backend both look for
/manifest.json, sothe default filename causes a 404 in production and prevents install
prompts from firing.
What this PR does
Sets
manifestFilename: "manifest.json"invite.config.tssoVitePWA writes the manifest at
/manifest.json(both in the devserver and in the production build output).
Removes
public/site.webmanifest– this was an empty placeholderwith incorrect icon paths. It is superseded by the manifest that
VitePWA generates from the plugin configuration.
Testing
Related
Companion PR in swingmx/swingmusic adds a
/manifest.jsonroute tothe Flask backend and a bundled fallback manifest for server-only
installs.